Skip to content

feat(e2ei): X509CredentialAcquisition from CredentialRef [WPB-25813]#2166

Merged
SimonThormeyer merged 16 commits into
mainfrom
simon/feat/acquisition-from-credential-ref
May 26, 2026
Merged

feat(e2ei): X509CredentialAcquisition from CredentialRef [WPB-25813]#2166
SimonThormeyer merged 16 commits into
mainfrom
simon/feat/acquisition-from-credential-ref

Conversation

@SimonThormeyer
Copy link
Copy Markdown
Member

@SimonThormeyer SimonThormeyer commented May 22, 2026 •
edited
Loading

What's new in this PR

See above

PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@SimonThormeyer SimonThormeyer force-pushed the simon/feat/acquisition-from-credential-ref branch 9 times, most recently from b790141 to d84736d Compare May 22, 2026 15:39
@SimonThormeyer SimonThormeyer changed the base branch from main to felix/swift-test-util May 22, 2026 15:40
@fewerner fewerner force-pushed the felix/swift-test-util branch from 95ebe14 to 9a47d93 Compare May 22, 2026 15:47
Base automatically changed from felix/swift-test-util to main May 25, 2026 07:24
@typfel typfel force-pushed the simon/feat/acquisition-from-credential-ref branch 2 times, most recently from 0601b48 to bf8c82e Compare May 25, 2026 08:12
@SimonThormeyer SimonThormeyer force-pushed the simon/feat/acquisition-from-credential-ref branch 9 times, most recently from ce600cf to a20c33a Compare May 26, 2026 09:03
@SimonThormeyer SimonThormeyer changed the title Simon/feat/acquisition from credential ref feat(e2ei): X509CredentialAcquisition from CredentialRef [WPB-25813] May 26, 2026
@SimonThormeyer SimonThormeyer marked this pull request as ready for review May 26, 2026 09:08
@SimonThormeyer SimonThormeyer requested a review from a team May 26, 2026 09:08
istankovic
istankovic reviewed May 26, 2026
View reviewed changes
Comment thread e2e-identity/src/acquisition/initial.rs Outdated
coriolinus
coriolinus approved these changes May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of nits. I think the asymmetry in cfg statements is strange, but in practice I imagine it'll always work out, so I'm approving anyway. But ideally there would be several fixups before merging.

Comment thread e2e-identity/src/acquisition/initial.rs Outdated
Comment thread e2e-identity/src/acquisition/initial.rs Outdated
Comment thread crypto-ffi/src/lib.rs
Comment thread crypto-ffi/src/e2ei/x509_credential_acquisition_from_credential_ref.rs Outdated
Comment thread crypto-ffi/src/e2ei/x509_credential_acquisition_from_credential_ref.rs Outdated
Comment thread crypto-ffi/src/e2ei/x509_credential_acquisition_from_credential_ref.rs
Comment thread crypto-ffi/bindings/shared/src/commonMain/kotlin/com/wire/crypto/MlsModel.kt
Comment thread crypto-ffi/bindings/swift/WireCoreCrypto/WireCoreCrypto/CoreCrypto.swift Outdated
@SimonThormeyer SimonThormeyer force-pushed the simon/feat/acquisition-from-credential-ref branch 2 times, most recently from bde165d to 5da4f0c Compare May 26, 2026 10:15
@SimonThormeyer
feat(e2ei): allow creating an X509 acquisition from pem
a8e5e9e 
This is temporary. See https://wearezeta.atlassian.net/wiki/x/RABtrQ.
@SimonThormeyer
chore(e2ei): allow parsing Pem from bytes
d37350c
@SimonThormeyer
chore(crypto): allow loading a single credential from ref
4727dcf
@SimonThormeyer
chore(crypto): allow getting a Credential's sign key bytes
545afeb 
This is needed to create a `Pem`.
@SimonThormeyer
refactor(crypto-ffi): simplify platform-specific Database instantia…
eb4aa9d 
…tions
@SimonThormeyer
feat(crypto-ffi): allow creating an X509 acquisition from `Credential…
acaa774 
…Ref` [WPB-25813]

The new constructor requires access to the core crypto database, which
can be provided as a parameter. The parameter can be omitted, in case
the PkiEnv DB and the CC DB are the same instance.
@SimonThormeyer
chore(ffi/ts): wrap X509CredentialAcquisition
5d2aa27 
We need it because ubrn doesn't currently support providing default
parameters in constructors.
@SimonThormeyer
test(ts): allow setting the database instance in ccInit()
17609a9
@SimonThormeyer
test(ts-browser): instantiating x509 acquisition from credential ref
794dd80
@SimonThormeyer
chore(ffi/kotlin): wrap free function
e5fbcb3 
This makes it look like we have an async static function, just like we
do in typescript.
@SimonThormeyer
test(kotlin): allow setting the database instance in ccInit()
05e5596
@SimonThormeyer
test(kotlin): instantiating x509 acquisition from credential ref
319c280
@SimonThormeyer
chore(ffi/swift): wrap free function
5884298 
This makes it look like we have an async static function, just like we
do in typescript.
@SimonThormeyer
test(swift): allow setting the database instance in ccInit()
5b2a209
@SimonThormeyer
test(swift): instantiating x509 acquisition from credential ref
fd8bc0e
@SimonThormeyer
chore(ts): ignore typedoc warning
e4a3dbb
@SimonThormeyer SimonThormeyer force-pushed the simon/feat/acquisition-from-credential-ref branch from 5da4f0c to e4a3dbb Compare May 26, 2026 10:18
@SimonThormeyer SimonThormeyer merged commit e4a3dbb into main May 26, 2026
62 checks passed
@SimonThormeyer SimonThormeyer deleted the simon/feat/acquisition-from-credential-ref branch May 26, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@istankovic istankovic istankovic left review comments

@coriolinus coriolinus coriolinus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonThormeyer @istankovic @coriolinus